fix: show scrollbar on hover in diff viewer#1610
Open
reverb256 wants to merge 2 commits intoPostHog:mainfrom
Open
fix: show scrollbar on hover in diff viewer#1610reverb256 wants to merge 2 commits intoPostHog:mainfrom
reverb256 wants to merge 2 commits intoPostHog:mainfrom
Conversation
Replace scrollbar-hide with scrollbar-overlay-y class that hides the scrollbar by default and reveals it on hover. This preserves the clean look adboio wanted while giving users scroll affordance. Follows the existing scrollbar-overlay (horizontal) pattern with matching color tokens (gray-a6/gray-a8). Fixes PostHog#1583
Contributor
Author
Visual EvidenceBefore → After: Scrollbar appears on hover in diff viewer
Replaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The diff viewer has no visible scrollbar, making it hard to navigate large diffs. As discussed in #1583, the scrollbar was intentionally hidden to avoid visual clutter from multiple scrollbars.
Solution
Replace
scrollbar-hidewith a newscrollbar-overlay-yCSS class that:This mirrors the existing
scrollbar-overlayclass (horizontal) but for vertical scrolling, using the same color tokens (--gray-a6/--gray-a8).Files changed
ReviewShell.tsx— swapscrollbar-hide→scrollbar-overlay-yglobals.css— addscrollbar-overlay-yutility class (followsscrollbar-overlaypattern)Fixes #1583